#10191 closed defect (duplicate)
Catch fatal Sphinx errors
Reported by: | jdemeyer | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | build | Keywords: | sphinx build docbuilder documentation |
Cc: | mvngu, leif | Merged in: | |
Authors: | Reviewers: | Jeroen Demeyer | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Ensure that the building of Sage aborts after a fatal Sphinx error. The build still continues after non-fatal errors or warnings.
The attached patch does this by raising a Python exception if Sphinx fails.
Obsoleted by #10200
Attachments (4)
Change History (21)
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Description modified (diff)
Changed 11 years ago by
comment:3 Changed 11 years ago by
- Description modified (diff)
comment:4 Changed 11 years ago by
- Description modified (diff)
comment:5 Changed 11 years ago by
- Description modified (diff)
comment:6 Changed 11 years ago by
comment:7 Changed 11 years ago by
- Merged in set to sage-4.6.1.alpha0
comment:8 Changed 11 years ago by
- Description modified (diff)
- Summary changed from Catch Sphinx errors to Catch fatal Sphinx errors
comment:9 Changed 11 years ago by
- Description modified (diff)
comment:10 follow-up: ↓ 12 Changed 11 years ago by
- Cc mvngu added
- Keywords docbuilder documentation added
I guess you haven't been aware of #9426...
There are two (almost) identical patches to the Sage library, where the .2
is the older one.
comment:11 Changed 11 years ago by
P.S.: Does Sphinx now also raise an error because of "then ``None`` wil be returned.
"?
comment:12 in reply to: ↑ 10 ; follow-up: ↓ 13 Changed 11 years ago by
Replying to leif:
I guess you haven't been aware of #9426...
True.
There are two (almost) identical patches to the Sage library, where the
.2
is the older one.
The .2 was a mistake by me, apply 10191_catch_sphinx_error.patch like the description of the ticket says :-)
Replying to leif:
P.S.: Does Sphinx now also raise an error because of "
then ``None`` wil be returned.
"?
I don't understand what you mean...
comment:13 in reply to: ↑ 12 ; follow-up: ↓ 14 Changed 11 years ago by
comment:14 in reply to: ↑ 13 Changed 11 years ago by
comment:15 Changed 11 years ago by
- Cc leif added
Any obstructions for this patch (10191_catch_sphinx_error.patch) to get positive review?
comment:16 Changed 11 years ago by
- Description modified (diff)
- Merged in sage-4.6.1.alpha0 deleted
- Resolution set to duplicate
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to closed
comment:17 Changed 11 years ago by
- Milestone changed from sage-4.6.1 to sage-duplicate/invalid/wontfix
Create a deliberate Sphinx error, for testing